Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: packaging error - "pkgdemo" #322

Closed
prjemian opened this issue Jan 13, 2024 · 5 comments · Fixed by #323
Closed

BUG: packaging error - "pkgdemo" #322

prjemian opened this issue Jan 13, 2024 · 5 comments · Fixed by #323
Assignees
Labels
Milestone

Comments

@prjemian
Copy link
Contributor

prjemian commented Jan 13, 2024

V1.1.0rc1 PyPA source dist published on PyPI but conda-forge recipe fails with exception importlib.metadata.PackageNotFoundError: No package metadata was found for pkgdemo. Here is the problem:

__version__ = version("pkgdemo")

The text pkgdemo should be replaced by this package's name: hkl.

@prjemian prjemian added the bug label Jan 13, 2024
@prjemian prjemian added this to the v1.1 milestone Jan 13, 2024
@prjemian prjemian self-assigned this Jan 13, 2024
@prjemian
Copy link
Contributor Author

Seems like a rookie mistake but this (not replacing pkgdemo with the current package name) happens far too often when transitioning the package versioning from versioneer to setuptools-scm. Just easy to overlook this one item.

@prjemian
Copy link
Contributor Author

Define a symbol with the package name and then use here instead of verbatim text.

@prjemian prjemian changed the title BUG: packaging error BUG: packaging error - "pkgdemo" Jan 13, 2024
@prjemian
Copy link
Contributor Author

Use the name as defined here:

name = "hklpy"

@prjemian
Copy link
Contributor Author

In [1]: from importlib.metadata import version

In [2]: version("hklpy")
Out[2]: '1.1.0rc1'

@prjemian
Copy link
Contributor Author

With this change:

In [1]: from importlib.metadata import version

In [2]: version("hklpy")
Out[2]: '1.1.0rc2.dev1+g1d2a8cd'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant