Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add properties: axes_r, axes_w, & axes_c #308

Closed
prjemian opened this issue Dec 8, 2023 · 0 comments · Fixed by #309
Closed

Add properties: axes_r, axes_w, & axes_c #308

prjemian opened this issue Dec 8, 2023 · 0 comments · Fixed by #309
Assignees
Milestone

Comments

@prjemian
Copy link
Contributor

prjemian commented Dec 8, 2023

Could add properties for axes_r (real-space axes as defined by libhkl that are used to calculate forward reflection) and axes_w (the axes to be updated by forward calculation). The axes in axes_r that are missing from axes_w are the ones held constant (a question posed recently by @strempfer), a new property called axes_c.

If the engine module has these properties, they would use the canonical names. Then, the calc module could also define the same properties and replace canonical with renamed axes. Makes it easier for the user to understand a given mode and engine.

Originally posted by @prjemian in #306 (comment)

@prjemian prjemian self-assigned this Dec 8, 2023
@prjemian prjemian added this to the v1.1 milestone Dec 8, 2023
prjemian added a commit that referenced this issue Dec 9, 2023
prjemian added a commit that referenced this issue Dec 9, 2023
prjemian added a commit that referenced this issue Dec 11, 2023
prjemian added a commit that referenced this issue Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant