-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert from BaseModel
to jsonschema
+ TypedDict
#343
Conversation
BaseModel
to jsonschema +
TypedDict`BaseModel
to jsonschema
+ TypedDict
88e3c04
to
176413f
Compare
Will probably streamline the system of adding extra json schema to BaseModels too |
176413f
to
1e860ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with this, and it didn't require any code changes so I think that means the checking for nulls is OK.
@danielballan please can you review the schema changes on projections?
Just to make sure, please can you point bluesky to this and run mypy src/bluesky
, then point ophyd-async at this and run pyright src/ophyd_async
and check it doesn't think we need to check for nulls anywhere?
Also, why is the test failing? |
There wasn't consistency in the order of the generated I'll wait for a review and then add an ADR and update the docs within this PR once we've decided. |
a683dc5
to
2195892
Compare
I tested that it's working against bluesky and ophyd-async, both tests and type checking. I had to write some custom code to include
|
2195892
to
895f19d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Incidentally I like the new usage, too. Good use of python -m ...
.
Was going to add tests for the |
Closes #337