Fix: to post positioning after thread load #1587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
reviewed
Oct 4, 2023
| @@ -367,7 +367,7 @@ export const PostThread = observer(function PostThread({ | |||
| data={posts} | |||
| initialNumToRender={posts.length} | |||
| maintainVisibleContentPosition={ | |||
| isNative && view.isFromCache | |||
| isNative && view.isFromCache && view.isCachedPostAReply | |||
There was a problem hiding this comment.
Wanna leave a comment mentioning the other case is broken? So that it's clear why the condition
There was a problem hiding this comment.
The other case isn't broken in the sense that this is a hackfix. This change is just another way to do it correctly -- if the post we're loading isnt a reply, we don't want to reposition.
gaearon
approved these changes
Oct 4, 2023
estrattonbailey
added a commit
that referenced
this pull request
Oct 9, 2023
…e-post-tags-into-app * origin/main: (40 commits) 1.52 README: tweaks to high-level context (#1625) Fix stuck lightbox header after double tap (#1627) Fix: add padding to the spinner bottom while loading threads (#1626) Rewrite Android lightbox (#1624) Dont trim before posting (close #1621) (#1622) Only listen to back button on android (#1623) Improve typeahead search with inclusion of followed users (temporary solution) (#1612) Slightly smaller highlighted post text (#1608) Pull upstream bugfixes to bottom-sheet (#1606) Fix animations and gestures getting reset on state updates in the lightbox (#1618) Remove unused lightbox options (#1616) Profile UI tweaks (#1607) Fix invite codes flash on desktop, use loading placeholder (#1591) Update to [email protected] (#1599) Fixed a typo on the onboarding recommended screen (#1604) Onboarding & feed fixes (#1602) Improve time to content in the search page (#1603) Fix a potential reference error in bottombarweb (#1600) Fix: only use scroll-positioning control on thread when looking at replies (#1587) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was noticing some cases where quote posts would position incorrectly after tapping them and loading their thread screen. I believe this is because the index passed to
maintainVisibleContentPositionis correct when rendering replies but not when rendering toplevel posts (you have to do some annoying component counting to establish the index).When viewing a toplevel post you don't need to do any scroll repositioning, so this PR checks that and disables it for non-replies.