Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moderation settings fixes #1336

Merged
merged 6 commits into from
Aug 30, 2023
Merged

Moderation settings fixes #1336

merged 6 commits into from
Aug 30, 2023

Conversation

pfrazee
Copy link
Collaborator

@pfrazee pfrazee commented Aug 30, 2023

  • Moves preference mutations to the SDK
  • FINALLY fixes the moderation sync issue with the adult content flag (close Content filtering sync between devices #633).
  • Fixes a race condition with saved feed updates (close race condition - get set preferences #1139). This was caused by failing to pull the latest saved feed state before doing add/remove mutations. The SDK now does that.
  • Removes the "Adult content can only be toggled" warning on iOS if adult content has been turned on, to reduce confusion.
  • Removes a bunch of dead code.

pfrazee added 5 commits August 29, 2023 12:09
@pfrazee
Default isAdultContentEnabled to false on all devices.
8d40346 
The original intent of setting the default based on the device was
to make the maximally-permissive choice. It turns out this was a
mistake as it created sync issues between devices; users would be
confused by the lack of congruity between them. We have to go with
false by default to ensure sync is retained.
@pfrazee
Update preferences model to use new sdk api
37cb7a3
@pfrazee
Delete dead code
0bca1ae
@pfrazee
Dont show the iOS adult content warning in content filtering settings…
b254bac 
… if adult content is enabled
@pfrazee
Bump @atproto/[email protected]
39cecfc
estrattonbailey
estrattonbailey approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@estrattonbailey estrattonbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Magic

ansh
ansh approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@ansh ansh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ seeing PRs that remove code

@pfrazee pfrazee merged commit a29f10a into main Aug 30, 2023
@pfrazee pfrazee deleted the moderation-settings-updates branch August 30, 2023 22:19
estrattonbailey added a commit that referenced this pull request Aug 30, 2023
@estrattonbailey
Merge remote-tracking branch 'origin' into eric/expo-49
67eaf73 
* origin:
  Move `PreferencesHomeFeed` to a screen instead of a modal (#1335)
  Moderation settings fixes (#1336)
  fix lightbox on search page (#1330)
  handle stuck state with granular android permissions
@Leah96xxx Leah96xxx mentioned this pull request Nov 26, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estrattonbailey estrattonbailey estrattonbailey approved these changes

@ansh ansh ansh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

race condition - get set preferences Content filtering sync between devices
3 participants
@pfrazee @estrattonbailey @ansh