sensor-logging: Fix subtitles to show data on the beggining and end of the video #1666
Conversation
There was a problem hiding this comment.
The generated files seem to make sense, but I'm having some issues with the playback lining up to have subtitles at the end of the files. Not sure if that's just VLC struggling to keep the correct timing with the matroska files, or if the fake source allowing strange framerates is contributing - potentially something to keep an eye on for later.
Some minor suggestions on the code comments:
src/libs/sensors-logging.ts
Outdated
| // Consider logs that start a little before the initial time and end a little after the final time, so we don't | ||
| // miss data on the start and end of the file. |
There was a problem hiding this comment.
| // Consider logs that start a little before the initial time and end a little after the final time, so we don't | |
| // miss data on the start and end of the file. | |
| // Consider logs that start a little before the initial time and end a little after the final time, | |
| // so we don't miss data at the start or end of the recording. |
src/libs/sensors-logging.ts
Outdated
| // Generate a object with the initial and final epoch of each log point | ||
| // To know the initial epoch, check the name of the key. To know the final epoch, check the epoch of the next point. |
There was a problem hiding this comment.
| // Generate a object with the initial and final epoch of each log point | |
| // To know the initial epoch, check the name of the key. To know the final epoch, check the epoch of the next point. | |
| // Generate an object with the initial and final epoch of each log point | |
| // The initial epoch is the name of the key, and the final epoch can be determined from the next point. |
| ...{ seconds: differenceInSeconds(new Date(logPoint.epoch), initialTime) }, | ||
| })) | ||
| const finalLog = sortedLogPoints.map((logPoint) => { | ||
| const seconds = Math.max(0, differenceInSeconds(new Date(logPoint.epoch), initialTime)) |
There was a problem hiding this comment.
There should probably be a comment here explaining that the max clips the first point to the start of the log - took me a while to confirm the logic.
Adding the comments before merging. |
rafaellehmkuhl
force-pushed
the
fix-subtitles-video-start-and-end
branch
from
777f5c3 to
02d44cc
Compare
Attached zip contains the result of this patch.
subtitles-test.zip
Fix #815.