-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add input widgets to configurable mini widgets check #1665
Add input widgets to configurable mini widgets check #1665
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not to use the same logic that we have for the other two and extend the isMiniWidgetConfigurable
object with the types for the input widgets?
Because all input widgets have to be configurable, so creating the type describing that might be unnecessary. What do you think? |
I think it would be better to have a single check, as it is today, using the same mecanhism, but if you prefer to use it the way it is, it would be better to create a function (e.g. isWidgetConfigurable(component, type)' so it doesn't grow the number of lines as it's happening now, which degrades code readability. |
Agreed, creating the function 👍 |
Signed-off-by: Arturo Manzoli <[email protected]>
1b648ed
to
6c51ab2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to fix the problem - nice! :-)
Modified the logic that checks if the mini widgets is configurable
Closes #1662