Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing option to add an action in the button input widget #1661

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Fix missing option to add an action in the button input widget #1661

merged 1 commit into from
Feb 5, 2025

Conversation

ArturoManzoli
Copy link
Contributor

@ArturoManzoli ArturoManzoli commented Feb 4, 2025 •
edited
Loading

Modified the v-if filtering method to include all types of custom elements flagged by isCustomElement

Closes #1575

ES-Alexander
ES-Alexander approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@ES-Alexander ES-Alexander left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, but with limited functionality because of #1535.

Also, reviewing this made me find #1662 and #1663.

@ArturoManzoli
Copy link
Contributor Author

This works, but with limited functionality because of #1535.

Also, reviewing this made me find #1662 and #1663.

Good that you pointed those out. They're already in the Q1 milestone. I'll prioritize them.

@ArturoManzoli ArturoManzoli merged commit 90c9c6f into bluerobotics:master Feb 5, 2025
11 checks passed
@rafaellehmkuhl rafaellehmkuhl changed the title Re enable the Button's Cockpit action selector Fix missing option to add an action in the button input widget Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ES-Alexander ES-Alexander ES-Alexander approved these changes

@rafaellehmkuhl rafaellehmkuhl Awaiting requested review from rafaellehmkuhl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: button Input widget has no Action selection
2 participants
@ArturoManzoli @ES-Alexander