-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow setting the value of data-lake variables with joystick buttons #1656
Allow setting the value of data-lake variables with joystick buttons #1656
Conversation
2ed4d66
to
cd4cd55
Compare
I haven't had a chance to test yet, but if this triggers on both press and release of buttons, it could be relevant to #1475 :-) |
Totally doable with this new architecture. The one reading the variable has full control on the implementation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feature is awesome and the code looks fine.
-
I was able to assign a button to a variable and its pressing was reflected on the data-lake variable value, as you can see on the spikes (graphic on the left).
-
The association was also available to the axis, though, I wasn't able to see the value from an analog axis reflected on the variable.
I successfully assigned the same variable to the axis 2, but moving it generated only zeros. (The graphic sliding on its X axis is axis 2 adding zeros on the data-lake variable.)
Should the association be available to the analog axis too?
Screenshare.-.2025-02-05.11_17_56.AM.mp4
On which data-lake variable? If it's the cockpit-memory-usage or the application-fps, it is normal, as the data-lake uses system resources, as expected.
No, this PR is meant only to add the feature to buttons for now, but a new one extending it to axis is on progress. |
Nice! |
I actually have this functionality ready in another branch. I'm just waiting for this PR and another one (that will open after this one) to open the one that adds triggers. I didn't want to put everything in the same to make the review easier/faster and also to make all changes clear in the changelog. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you said that there is another PR coming very soon that binds axes to data-lake variables, it's ok to keep this function enabled on this merge.
This works for both boolean and floating buttons, so one can use trigger/bumper buttons as well.
Fix #1657