Use standard key names for the settings on storage #1646
Merged
+187
−178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaellehmkuhl
force-pushed
the
use-standard-key-name
branch
from
282a716 to
25680b5
Compare
rafaellehmkuhl
force-pushed
the
use-standard-key-name
branch
from
25680b5 to
89c1667
Compare
As we serve the interface in IPs that can vary, this makes it clear that the key is ours and not from another application.
It initially contains the renaming migrations of localStorage keys
rafaellehmkuhl
force-pushed
the
use-standard-key-name
branch
2 times, most recently
from
b011f9a to
a7a08ee
Compare
ArturoManzoli
requested changes
Feb 5, 2025
There was a problem hiding this comment.
Some issues noticed:
-
On the step 5 (Vehicle address) the 'General configuration' submenu isn't opening to show the user the form field where he can enter the vehicle's network address.
-
The 'Enter' key jumps from 'Interface' to 'Telemetry' and then to 'Mission'; not showing the steps between them. Also the Enter key doesn't work on the 5th step 'Vehicle address'.
rafaellehmkuhl
force-pushed
the
use-standard-key-name
branch
from
a7a08ee to
73eca49
Compare
rafaellehmkuhl
force-pushed
the
use-standard-key-name
branch
from
73eca49 to
ef34257
Compare
This logic was broken indeed. Fixed.
This was actually a logic that was already there, but with the changes in the next-step/before-step logic it does not need to exist anymore indeed. I've also took the opportunity of the new logic to add a listening for |
ArturoManzoli
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Putting on draft since I realized the stepping is broke on master. Will fix before opening it for review.
Fix #1442
Fix #1647