-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add constant proportion icons to Main-menu #1643
Add constant proportion icons to Main-menu #1643
Conversation
Should wait for #1595 to be merged. |
Agreed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Icon consistency seems to work - nice! 😃
- For some reason the (taller) internal menu spreads out the text extra, and goes past the top and bottom, without the sidebar being scrollable
- Not sure if this is intended to be fixed in Create Tools menu #1595 instead or something 🤷
Screen.Recording.2025-02-04.at.4.27.29.am.mov
#1595 should help with this as it's getting two of those submenus out of this menu, but I think the long term solution belongs to a further PR addressing #1645. Both #1595 as well as this one fix other bugs that are currently on master and have similar or higher criticality, so I believe it would be better not to increase their scope right now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Base bug is fixed, so let's get this in and fix the menu scaling stuff later :-)
@ArturoManzoli just need to rebase this over master and we can merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Arturo Manzoli <[email protected]>
0334d9a
to
bb06bf5
Compare
Thanks for pointing that out. Some margin settings were missing. |
Yep, thanks for pointing that out! Its fixed now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Arturo Manzoli <[email protected]>
bb06bf5
to
5c45cb1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything seems to be working fine now!
Nice work!
Adds custom svg icons to the main menu, so they will keep constant proportions and will never be off-center again.
Icons are in a Figma template with the rest of the Cockpit mockups. When adding a new item on the main menu, just drag the mdi icon svg inside an empty circle, resize it and export as an svg.
Screenshare.-.2025-02-03.11_58_20.AM.mp4
Fix #1445