Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

video: Allow user to choose between zipping multiple video files or not #1100

Conversation

rafaellehmkuhl
Copy link
Member

@rafaellehmkuhl rafaellehmkuhl commented Jul 11, 2024

Download files separately by default. This makes the download process instantaneous, which is specially important on longer videos.

The user can choose in the video configuration menu if they want to zip by default.

Fix #1076.

This makes the download process instantaneous, which is specially important on longer videos.
This commit adds the option to zip multiple video files for download. By default, the files are downloaded separately, but when multiple files are selected (like when there's a subtitle file involved), they can now be zipped into a single file for convenience.
@rafaellehmkuhl rafaellehmkuhl force-pushed the allow-directly-downloading-videos branch from c1d14be to e62186a Compare July 11, 2024 17:18
@rafaellehmkuhl rafaellehmkuhl marked this pull request as ready for review July 11, 2024 17:20
@rafaellehmkuhl rafaellehmkuhl changed the title video: Only zip unprocessed chunks, otherwise download files separately video: Allow user to choose between zipping multiple video files or not Jul 11, 2024
Copy link
Contributor

@ArturoManzoli ArturoManzoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, adding persistent options has never been so easy.

@ArturoManzoli ArturoManzoli merged commit d738fb1 into bluerobotics:master Jul 11, 2024
8 checks passed
@rafaellehmkuhl rafaellehmkuhl deleted the allow-directly-downloading-videos branch July 11, 2024 17:49
@ES-Alexander ES-Alexander added the docs-needed Change needs to be documented label Aug 8, 2024
@ES-Alexander ES-Alexander added the docs-in-progress Included in an open docs PR label Jan 2, 2025
@ES-Alexander ES-Alexander added docs-complete Change documentation has been completed and removed docs-needed Change needs to be documented docs-in-progress Included in an open docs PR labels Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-complete Change documentation has been completed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preparing the download of really large videos takes a lot of time
3 participants