core: frontend: Add menu items to home #899
Conversation
Williangalvani
commented
Mar 23, 2022
Williangalvani
commented
Williangalvani
force-pushed
the
home-cards
branch
from
fb1d8d0 to
439c258
Compare
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Can you just do:
| } | |
| for (const item of this.menus) { | |
| for (const subitem of item.submenus) { | |
| if (!subitem?.advanced || this.settings.is_pirate_mode) { | |
| items.push(subitem) | |
| } | |
| } | |
| } |
There was a problem hiding this comment.
not all of them have submenus defined, typescript complains about it without the check. I did something else you may like, tho...
core/frontend/src/menus.ts
Outdated
| text: 'General Autopilot settings, allow you to start/stop Ardupilot if using Navigator or SITL, and switch' | ||
| + ' boards if more than one is present', |
There was a problem hiding this comment.
This is a bit unclear to me, is this a correct understanding?
| text: 'General Autopilot settings, allow you to start/stop Ardupilot if using Navigator or SITL, and switch' | |
| + ' boards if more than one is present', | |
| text: 'General autopilot settings: allow you to start/stop Ardupilot firmware if using Navigator or SITL, and switch' | |
| + ' boards if more than one is present', |
I'm also not certain what "switch boards" means - is the assumption that the others are idle/off if not 'active', or could they all be on and doing stuff, and this just changes which one BlueOS is actively controlling/doing stuff with?
There was a problem hiding this comment.
IIRC it is for switching between navigator and pixhawk for people who happen to plug both in simultaneously. we could omit that, lol.
core/frontend/src/menus.ts
Outdated
| { | ||
| title: 'Firmware', | ||
| icon: 'mdi-chip', | ||
| route: '/autopilot/firmware', | ||
| advanced: false, | ||
| text: 'Used to download and flash new firmware to your board', | ||
| }, |
There was a problem hiding this comment.
Does it make sense to document this as a separate page, or is the combined page happening very soon?
Should possibly specify that it flashes to the "actively selected board", or "current board" or something
There was a problem hiding this comment.
the change is trivial to do after we merge them, I think this isn't an issue. I renamed to "current flight controller"
core/frontend/src/menus.ts
Outdated
| text: 'Manage Mavlink endpoints for internal/external systems. Used this if you need to connect additional' | ||
| + ' mavlink systems to your vehicle', |
There was a problem hiding this comment.
| text: 'Manage Mavlink endpoints for internal/external systems. Used this if you need to connect additional' | |
| + ' mavlink systems to your vehicle', | |
| text: 'Manage MAVLink endpoints for internal/external systems. Use this if you need to connect additional' | |
| + ' MAVLink systems to your vehicle', |
core/frontend/src/menus.ts
Outdated
| icon: 'mdi-map-marker', | ||
| route: '/tools/nmea-injector', | ||
| advanced: true, | ||
| text: 'Used for forwarding UDP NMEA stream into Ardupilot', |
There was a problem hiding this comment.
| text: 'Used for forwarding UDP NMEA stream into Ardupilot', | |
| text: 'Used for forwarding UDP NMEA streams into Ardupilot', |
Or should this be one? ("a UDP NMEA stream")
| icon: 'mdi-speedometer', | ||
| route: '/tools/network-test', | ||
| show: true, | ||
| text: 'Test link speed between topside computer and your vehicle', |
There was a problem hiding this comment.
I like this for sub, although I'm assuming drone users don't refer to the GCS as a "topside" computer? Not sure what our preference is here (do we want default sub terminology, or actively keep things general to ArduPilot vehicles?)
There was a problem hiding this comment.
we're currently walking the line... I don't want to be in any sides too much 😅
see my previous comment about "flight controller"
There was a problem hiding this comment.
I can just remove the "topside" reference
core/frontend/src/menus.ts
Outdated
| text: 'Used for forwarding UDP NMEA stream into Ardupilot', | ||
| }, | ||
| { | ||
| title: 'System information', |
There was a problem hiding this comment.
| title: 'System information', | |
| title: 'System Information', |
core/frontend/src/menus.ts
Outdated
| text: 'Detailed system status information, CPU, memory, disk, and ethernet status', | ||
| }, | ||
| { | ||
| title: 'Network test', |
There was a problem hiding this comment.
| title: 'Network test', | |
| title: 'Network Test', |
core/frontend/src/menus.ts
Outdated
| text: 'View detailed MAVLink traffic coming from your vehicle', | ||
| }, | ||
| { | ||
| title: 'Version-chooser', |
There was a problem hiding this comment.
| title: 'Version-chooser', | |
| title: 'Version Chooser', |
core/frontend/src/menus.ts
Outdated
| icon: 'mdi-cellphone-arrow-down', | ||
| route: '/tools/version-chooser', | ||
| advanced: false, | ||
| text: 'Manage versions and update to latest available', |
There was a problem hiding this comment.
| text: 'Manage versions and update to latest available', | |
| text: 'Manage BlueOS versions and update to the latest available', |
Williangalvani
force-pushed
the
home-cards
branch
from
439c258 to
c0a0d40
Compare
