Core: create Beacon #878
Merged
Core: create Beacon #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
no idea of how I closed this -.- |
Williangalvani
force-pushed
the
beacon
branch
6 times, most recently
from
581d226 to
0b439bc
Compare
patrickelectric
requested changes
Mar 19, 2022
Williangalvani
force-pushed
the
beacon
branch
4 times, most recently
from
ebbc64a to
f5579c3
Compare
patrickelectric
requested changes
Mar 20, 2022
This should be fixed in the latest image. as a side-effect, it now handles changes in settings/interfaces |
patrickelectric
requested changes
Mar 21, 2022
Williangalvani
force-pushed
the
beacon
branch
7 times, most recently
from
c7652c0 to
8a6ac89
Compare
patrickelectric
requested changes
Mar 22, 2022
| exit 1 | ||
| ) | ||
| sed -i "s/#host-name=foo/host-name=blueos-avahi/g" ${AVAHI_DAEMON_CONFIG_PATH} | ||
|
|
There was a problem hiding this comment.
This appears to be a bit weird, why are we failing if avahi is not available since is not required for the system to work (since now we have beacon).
Also, the cat will make all other lines to not work.
The correct would be:
Suggested change
| AVAHI_DAEMON_CONFIG_PATH="/etc/avahi/avahi-daemon.conf" | |
| AVAHI_HOST_NAME="blueos-avahi" | |
| [ ! -d "${AVAHI_DAEMON_CONFIG_PATH}" ] && ( | |
| echo "Avahi daemon config file found, changing avahi host name to: ${AVAHI_HOST_NAME}" | |
| sed -i "s/#host-name=/host-name=blueos-avahi/g" ${AVAHI_DAEMON_CONFIG_PATH} | |
| ) || echo "Avahi daemon config file not found in ${AVAHI_DAEMON_CONFIG_PATH}" |
This also remove the old "foo" name to make the command more future proof.
Williangalvani
force-pushed
the
beacon
branch
2 times, most recently
from
edbf029 to
76acb04
Compare
patrickelectric
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very configurable mDNS alternative to avahi.
fix #472
fix #360
fix #849
lays the groundwork for #680
image is live at williangalvani/blueos-core:beacon
I'll go through this one more time to tidy up and add comments/logging/better exception handling