core: version-chooser: fix checking for remote tags with 'companion-core' #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -219,7 +219,7 @@ async def get_available_versions(self, repository: str) -> web.Response: | |||
| for image in await self.client.images.list(): | |||
| if not image["RepoTags"]: | |||
| continue | |||
| if not any("companion-core" in tag for tag in image["RepoTags"]): | |||
| if not any(tag.startswith("companion-core:") for tag in image["RepoTags"]): | |||
There was a problem hiding this comment.
Can we also make it valid for blueos-core ?
There was a problem hiding this comment.
I think that belongs on it's own pr adding support for blueos-core
patrickelectric
approved these changes
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #384
image being built: williangalvani/companion-core:fix_tag_check