Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Frontend: InstalledExtensionCard: Fix has update available for stable versions #3060

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Core: Frontend: InstalledExtensionCard: Fix has update available for stable versions #3060

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion core/frontend/src/components/kraken/cards/InstalledExtensionCard.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,11 @@ export default Vue.extend({
const current_version = new semver.SemVer(this.extension.tag)
// if is stable (which implies major >= 1), show latest stable
if (stable.is(this.extension.tag) && current_version.major > 0) {
return stable.max(versions) === this.extension.tag ? false : stable.max(versions)
const latest = stable.max(versions)
if (semver.compare(this.extension.tag, latest) >= 0) {
return false
}
return latest
}
// show the latest version regardless of stability
// eslint-disable-next-line no-extra-parens
Expand Down
Loading