Warn users when deleting current IP being used or the last interface IP #2427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoaoMario109
force-pushed
the
2406-warn-delete-ips
branch
from
bc42630 to
24434e2
Compare
JoaoMario109
force-pushed
the
2406-warn-delete-ips
branch
from
24434e2 to
76e2741
Compare
|
Changed to have this implementation without directly depending on #2426 since its not defined when it will be able to merge |
JoaoMario109
requested review from
patrickelectric,
joaoantoniocardoso and
Williangalvani
JoaoMario109
force-pushed
the
2406-warn-delete-ips
branch
from
d2c36cf to
a6b30be
Compare
joaoantoniocardoso
approved these changes
Mar 14, 2024
core/frontend/src/components/ethernet/AddressDeletionDialog.vue
Outdated
Show resolved
Hide resolved
core/frontend/src/components/ethernet/AddressDeletionDialog.vue
Outdated
Show resolved
Hide resolved
core/frontend/src/components/ethernet/AddressDeletionDialog.vue
Outdated
Show resolved
Hide resolved
core/frontend/src/components/ethernet/AddressDeletionDialog.vue
Outdated
Show resolved
Hide resolved
* Add a check layer prior to deleting IPs on interfaces avoiding to delete the last IP or curently being useed IP by mistake
* Add a check layer prior to disconnecting from the WiFi network currently being used to access BlueOS
JoaoMario109
force-pushed
the
2406-warn-delete-ips
branch
from
a6b30be to
a782051
Compare
joaoantoniocardoso
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the check for when the user is trying to delete the IP being used to connect to BlueOS or when trying to delete the last IP of some interface.
Closes #2406