Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: operator fee not correctly called #2050

Merged
merged 1 commit into from
Feb 6, 2025
Merged

fix: operator fee not correctly called #2050

merged 1 commit into from
Feb 6, 2025

Conversation

leruaa
Copy link
Contributor

@leruaa leruaa commented Feb 5, 2025

This PR fixes 2 bugs:

  • The refund wasn't divided by OPERATOR_FEE_SCALAR_DECIMAL
  • The operator fee was badly taken into account when the input is empty. I added similar checks as L1 fee.

@leruaa leruaa force-pushed the fix-operator-fee-scalars-ordering branch from 56404d6 to 5233573 Compare February 5, 2025 19:26
rakita
rakita approved these changes Feb 6, 2025
View reviewed changes
Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rakita rakita merged commit 2c9290a into bluealloy:release/v55 Feb 6, 2025
18 of 22 checks passed
This was referenced Feb 7, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rakita rakita rakita approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leruaa @rakita