Fix diff for multiple platform filters #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #132 +/- ##
==========================================
- Coverage 97.04% 95.99% -1.06%
==========================================
Files 50 52 +2
Lines 2874 3019 +145
==========================================
+ Hits 2789 2898 +109
- Misses 85 121 +36 ☔ View full report in Codecov by Sentry. |
kwridan
force-pushed
the
fix/multiple-platform-filters
branch
from
5664205 to
4e1794c
Compare
resolves: bloomberg#130 - Multiple platform filters can now be applied to build files in Xcode - This includes most build files available in the various build phases (e.g. sources, resources, headers, linked, etc...) - A build file diff helper was introduced to allow adding the platform diff to the the existing comparators - Tests and fixtures were updated to account for multiple platform filters Test Plan: - Run xcdiff against the new fixtures, inspect and verify the results ```sh swift run xcdiff -p1 Fixtures/app_with_platform_filters_1/AppWithPlatformFilters.xcodeproj -p2 Fixtures/app_with_platform_filters_2/AppWithPlatformFilters.xcodeproj -v ``` Signed-off-by: Kassem Wridan <[email protected]>
kwridan
force-pushed
the
fix/multiple-platform-filters
branch
from
4e1794c to
fd1d07f
Compare
|
@marciniwanicki this should now be ready :) |
marciniwanicki
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number of the reported bug or feature request: #130
resolves: #130
Describe your changes
Testing performed