Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix -WConversion warnings in bmqtool storage inspector #415

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

bbpetukhov
Copy link
Contributor

*Issue number of the reported bug or feature request: #87 *

Describe your changes
This is a small good first issue contribution to fix -Wconversion warnings that pollutes the build log.

This particular PR deals with the following warnings in bmqtool storage inspector:

2024-08-29T09:06:08.2897431Z [425/433] Building CXX object src/applications/bmqtool/CMakeFiles/bmqtool_lib.dir/m_bmqtool_storageinspector.cpp.o
2024-08-29T09:06:08.2902142Z /home/runner/work/blazingmq/blazingmq/src/applications/bmqtool/m_bmqtool_storageinspector.cpp: In instantiation of ‘void BloombergLP::m_bmqtool::{anonymous}::iterateNextPosition(CHOICE&, BloombergLP::mqbs::MappedFileDescriptor*, ITER*, const char*) [with CHOICE = const BloombergLP::m_bmqtool::DataCommandChoice; ITER = BloombergLP::mqbs::DataFileIterator]’:
2024-08-29T09:06:08.2906081Z /home/runner/work/blazingmq/blazingmq/src/applications/bmqtool/m_bmqtool_storageinspector.cpp:754:24:   required from here
2024-08-29T09:06:08.2909643Z /home/runner/work/blazingmq/blazingmq/src/applications/bmqtool/m_bmqtool_storageinspector.cpp:145:17: warning: conversion from ‘BloombergLP::bsls::Types::Uint64’ {aka ‘long long unsigned int’} to ‘int’ may change value [-Wconversion]
2024-08-29T09:06:08.2911885Z   145 |         skip    = choice.n();
2024-08-29T09:06:08.2912444Z       |         ~~~~~~~~^~~~~~~~~~~~
2024-08-29T09:06:08.2915096Z /home/runner/work/blazingmq/blazingmq/src/applications/bmqtool/m_bmqtool_storageinspector.cpp:149:17: warning: conversion from ‘BloombergLP::bsls::Types::Uint64’ {aka ‘long long unsigned int’} to ‘int’ may change value [-Wconversion]
2024-08-29T09:06:08.2917394Z   149 |         skip    = choice.next();
2024-08-29T09:06:08.2917978Z       |         ~~~~~~~~^~~~~~~~~~~~~~~
2024-08-29T09:06:08.2920587Z /home/runner/work/blazingmq/blazingmq/src/applications/bmqtool/m_bmqtool_storageinspector.cpp:153:17: warning: conversion from ‘BloombergLP::bsls::Types::Uint64’ {aka ‘long long unsigned int’} to ‘int’ may change value [-Wconversion]
2024-08-29T09:06:08.2922847Z   153 |         skip    = choice.p();
2024-08-29T09:06:08.2923660Z       |         ~~~~~~~~^~~~~~~~~~~~
2024-08-29T09:06:08.2926275Z /home/runner/work/blazingmq/blazingmq/src/applications/bmqtool/m_bmqtool_storageinspector.cpp:157:17: warning: conversion from ‘BloombergLP::bsls::Types::Uint64’ {aka ‘long long unsigned int’} to ‘int’ may change value [-Wconversion]
2024-08-29T09:06:08.2928575Z   157 |         skip    = choice.prev();
2024-08-29T09:06:08.2929174Z       |         ~~~~~~~~^~~~~~~~~~~~~~~
2024-08-29T09:06:08.2932285Z /home/runner/work/blazingmq/blazingmq/src/applications/bmqtool/m_bmqtool_storageinspector.cpp:160:14: warning: conversion from ‘BloombergLP::bsls::Types::Uint64’ {aka ‘long long unsigned int’} to ‘int’ may change value [-Wconversion]
2024-08-29T09:06:08.2934564Z   160 |         skip = choice.record();
2024-08-29T09:06:08.2935143Z       |         ~~~~~^~~~~~~~~~~~~~~~~
2024-08-29T09:06:08.2937751Z /home/runner/work/blazingmq/blazingmq/src/applications/bmqtool/m_bmqtool_storageinspector.cpp:164:18: warning: conversion from ‘BloombergLP::bsls::Types::Uint64’ {aka ‘long long unsigned int’} to ‘int’ may change value [-Wconversion]
2024-08-29T09:06:08.2939943Z   164 |             skip = choice.r();
2024-08-29T09:06:08.2940514Z       |             ~~~~~^~~~~~~~~~~~
2024-08-29T09:06:08.2943178Z /home/runner/work/blazingmq/blazingmq/src/applications/bmqtool/m_bmqtool_storageinspector.cpp:169:18: warning: conversion from ‘BloombergLP::bsls::Types::Uint64’ {aka ‘long long unsigned int’} to ‘int’ may change value [-Wconversion]
2024-08-29T09:06:08.2945923Z   169 |             skip -= iter->recordIndex();
2024-08-29T09:06:08.2946589Z       |             ~~~~~^~~~~~~~~~~~~~~~~~~~~~
2024-08-29T09:06:08.2949215Z /home/runner/work/blazingmq/blazingmq/src/applications/bmqtool/m_bmqtool_storageinspector.cpp:173:43: warning: conversion from ‘BloombergLP::bsls::Types::Uint64’ {aka ‘long long unsigned int’} to ‘int’ may change value [-Wconversion]
2024-08-29T09:06:08.2951694Z   173 |             skip    = iter->recordIndex() - skip;
2024-08-29T09:06:08.2952427Z       |                       ~~~~~~~~~~~~~~~~~~~~^~~~~~
2024-08-29T09:06:08.2956122Z /home/runner/work/blazingmq/blazingmq/src/applications/bmqtool/m_bmqtool_storageinspector.cpp: In instantiation of ‘void BloombergLP::m_bmqtool::{anonymous}::iterateNextPosition(CHOICE&, BloombergLP::mqbs::MappedFileDescriptor*, ITER*, const char*) [with CHOICE = const BloombergLP::m_bmqtool::QlistCommandChoice; ITER = BloombergLP::mqbs::QlistFileIterator]’:
2024-08-29T09:06:08.2960160Z /home/runner/work/blazingmq/blazingmq/src/applications/bmqtool/m_bmqtool_storageinspector.cpp:767:24:   required from here
2024-08-29T09:06:08.2964091Z /home/runner/work/blazingmq/blazingmq/src/applications/bmqtool/m_bmqtool_storageinspector.cpp:145:17: warning: conversion from ‘BloombergLP::bsls::Types::Uint64’ {aka ‘long long unsigned int’} to ‘int’ may change value [-Wconversion]
2024-08-29T09:06:08.2966385Z   145 |         skip    = choice.n();
2024-08-29T09:06:08.2966981Z       |         ~~~~~~~~^~~~~~~~~~~~
2024-08-29T09:06:08.2969631Z /home/runner/work/blazingmq/blazingmq/src/applications/bmqtool/m_bmqtool_storageinspector.cpp:149:17: warning: conversion from ‘BloombergLP::bsls::Types::Uint64’ {aka ‘long long unsigned int’} to ‘int’ may change value [-Wconversion]
2024-08-29T09:06:08.2971894Z   149 |         skip    = choice.next();
2024-08-29T09:06:08.2972478Z       |         ~~~~~~~~^~~~~~~~~~~~~~~
2024-08-29T09:06:08.2975174Z /home/runner/work/blazingmq/blazingmq/src/applications/bmqtool/m_bmqtool_storageinspector.cpp:153:17: warning: conversion from ‘BloombergLP::bsls::Types::Uint64’ {aka ‘long long unsigned int’} to ‘int’ may change value [-Wconversion]
2024-08-29T09:06:08.2977442Z   153 |         skip    = choice.p();
2024-08-29T09:06:08.2978002Z       |         ~~~~~~~~^~~~~~~~~~~~
2024-08-29T09:06:08.2980598Z /home/runner/work/blazingmq/blazingmq/src/applications/bmqtool/m_bmqtool_storageinspector.cpp:157:17: warning: conversion from ‘BloombergLP::bsls::Types::Uint64’ {aka ‘long long unsigned int’} to ‘int’ may change value [-Wconversion]
2024-08-29T09:06:08.2982831Z   157 |         skip    = choice.prev();
2024-08-29T09:06:08.2983418Z       |         ~~~~~~~~^~~~~~~~~~~~~~~
2024-08-29T09:06:08.2985994Z /home/runner/work/blazingmq/blazingmq/src/applications/bmqtool/m_bmqtool_storageinspector.cpp:160:14: warning: conversion from ‘BloombergLP::bsls::Types::Uint64’ {aka ‘long long unsigned int’} to ‘int’ may change value [-Wconversion]
2024-08-29T09:06:08.2988390Z   160 |         skip = choice.record();
2024-08-29T09:06:08.2988949Z       |         ~~~~~^~~~~~~~~~~~~~~~~
2024-08-29T09:06:08.2991384Z /home/runner/work/blazingmq/blazingmq/src/applications/bmqtool/m_bmqtool_storageinspector.cpp:164:18: warning: conversion from ‘BloombergLP::bsls::Types::Uint64’ {aka ‘long long unsigned int’} to ‘int’ may change value [-Wconversion]
2024-08-29T09:06:08.2993379Z   164 |             skip = choice.r();
2024-08-29T09:06:08.2993882Z       |             ~~~~~^~~~~~~~~~~~
2024-08-29T09:06:08.2996277Z /home/runner/work/blazingmq/blazingmq/src/applications/bmqtool/m_bmqtool_storageinspector.cpp:169:18: warning: conversion from ‘BloombergLP::bsls::Types::Uint64’ {aka ‘long long unsigned int’} to ‘int’ may change value [-Wconversion]
2024-08-29T09:06:08.2998597Z   169 |             skip -= iter->recordIndex();
2024-08-29T09:06:08.2999210Z       |             ~~~~~^~~~~~~~~~~~~~~~~~~~~~
2024-08-29T09:06:08.3001806Z /home/runner/work/blazingmq/blazingmq/src/applications/bmqtool/m_bmqtool_storageinspector.cpp:173:43: warning: conversion from ‘BloombergLP::bsls::Types::Uint64’ {aka ‘long long unsigned int’} to ‘int’ may change value [-Wconversion]
2024-08-29T09:06:08.3004513Z   173 |             skip    = iter->recordIndex() - skip;
2024-08-29T09:06:08.3005183Z       |                       ~~~~~~~~~~~~~~~~~~~~^~~~~~
2024-08-29T09:06:08.3008570Z /home/runner/work/blazingmq/blazingmq/src/applications/bmqtool/m_bmqtool_storageinspector.cpp: In instantiation of ‘void BloombergLP::m_bmqtool::{anonymous}::iterateNextPosition(CHOICE&, BloombergLP::mqbs::MappedFileDescriptor*, ITER*, const char*) [with CHOICE = BloombergLP::m_bmqtool::JournalCommandChoice; ITER = BloombergLP::mqbs::JournalFileIterator]’:
2024-08-29T09:06:08.3012209Z /home/runner/work/blazingmq/blazingmq/src/applications/bmqtool/m_bmqtool_storageinspector.cpp:872:24:   required from here
2024-08-29T09:06:08.3015372Z /home/runner/work/blazingmq/blazingmq/src/applications/bmqtool/m_bmqtool_storageinspector.cpp:145:17: warning: conversion from ‘BloombergLP::bsls::Types::Uint64’ {aka ‘long long unsigned int’} to ‘int’ may change value [-Wconversion]
2024-08-29T09:06:08.3017270Z   145 |         skip    = choice.n();
2024-08-29T09:06:08.3017793Z       |         ~~~~~~~~^~~~~~~~~~~~
2024-08-29T09:06:08.3020282Z /home/runner/work/blazingmq/blazingmq/src/applications/bmqtool/m_bmqtool_storageinspector.cpp:149:17: warning: conversion from ‘BloombergLP::bsls::Types::Uint64’ {aka ‘long long unsigned int’} to ‘int’ may change value [-Wconversion]
2024-08-29T09:06:08.3022428Z   149 |         skip    = choice.next();
2024-08-29T09:06:08.3022980Z       |         ~~~~~~~~^~~~~~~~~~~~~~~
2024-08-29T09:06:08.3025327Z /home/runner/work/blazingmq/blazingmq/src/applications/bmqtool/m_bmqtool_storageinspector.cpp:153:17: warning: conversion from ‘BloombergLP::bsls::Types::Uint64’ {aka ‘long long unsigned int’} to ‘int’ may change value [-Wconversion]
2024-08-29T09:06:08.3027407Z   153 |         skip    = choice.p();
2024-08-29T09:06:08.3027940Z       |         ~~~~~~~~^~~~~~~~~~~~
2024-08-29T09:06:08.3030405Z /home/runner/work/blazingmq/blazingmq/src/applications/bmqtool/m_bmqtool_storageinspector.cpp:157:17: warning: conversion from ‘BloombergLP::bsls::Types::Uint64’ {aka ‘long long unsigned int’} to ‘int’ may change value [-Wconversion]
2024-08-29T09:06:08.3032567Z   157 |         skip    = choice.prev();
2024-08-29T09:06:08.3033091Z       |         ~~~~~~~~^~~~~~~~~~~~~~~
2024-08-29T09:06:08.3035629Z /home/runner/work/blazingmq/blazingmq/src/applications/bmqtool/m_bmqtool_storageinspector.cpp:160:14: warning: conversion from ‘BloombergLP::bsls::Types::Uint64’ {aka ‘long long unsigned int’} to ‘int’ may change value [-Wconversion]
2024-08-29T09:06:08.3037753Z   160 |         skip = choice.record();
2024-08-29T09:06:08.3038278Z       |         ~~~~~^~~~~~~~~~~~~~~~~
2024-08-29T09:06:08.3040932Z /home/runner/work/blazingmq/blazingmq/src/applications/bmqtool/m_bmqtool_storageinspector.cpp:164:18: warning: conversion from ‘BloombergLP::bsls::Types::Uint64’ {aka ‘long long unsigned int’} to ‘int’ may change value [-Wconversion]
2024-08-29T09:06:08.3245827Z   164 |             skip = choice.r();
2024-08-29T09:06:08.3246729Z       |             ~~~~~^~~~~~~~~~~~
2024-08-29T09:06:08.3249492Z /home/runner/work/blazingmq/blazingmq/src/applications/bmqtool/m_bmqtool_storageinspector.cpp:169:18: warning: conversion from ‘BloombergLP::bsls::Types::Uint64’ {aka ‘long long unsigned int’} to ‘int’ may change value [-Wconversion]
2024-08-29T09:06:08.3251857Z   169 |             skip -= iter->recordIndex();
2024-08-29T09:06:08.3252504Z       |             ~~~~~^~~~~~~~~~~~~~~~~~~~~~
2024-08-29T09:06:08.3255052Z /home/runner/work/blazingmq/blazingmq/src/applications/bmqtool/m_bmqtool_storageinspector.cpp:173:43: warning: conversion from ‘BloombergLP::bsls::Types::Uint64’ {aka ‘long long unsigned int’} to ‘int’ may change value [-Wconversion]
2024-08-29T09:06:08.3257378Z   173 |             skip    = iter->recordIndex() - skip;
2024-08-29T09:06:08.3258120Z       |                       ~~~~~~~~~~~~~~~~~~~~^~~~~~

Testing performed

  • Successfully passed checks in Actions/Workflow
  • Successfully passed Jenkins custom build run for Linux

Additional context

@bbpetukhov bbpetukhov requested a review from a team as a code owner September 4, 2024 16:23
Copy link
Collaborator

@678098 678098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to apply clang-format

@bbpetukhov bbpetukhov force-pushed the fix-wconversion-warnings branch from 1dd5d08 to 0f4b8b9 Compare September 5, 2024 10:04
@bbpetukhov bbpetukhov requested a review from 678098 September 5, 2024 12:54
@678098 678098 merged commit 34be90f into bloomberg:main Sep 5, 2024
29 checks passed
alexander-e1off pushed a commit to alexander-e1off/blazingmq that referenced this pull request Oct 24, 2024
alexander-e1off pushed a commit to alexander-e1off/blazingmq that referenced this pull request Oct 24, 2024
alexander-e1off pushed a commit to alexander-e1off/blazingmq that referenced this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants