Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor[MQBSTAT]: fix unnamed namespace forward declaration warning #369

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

678098
Copy link
Collaborator

@678098 678098 commented Jul 23, 2024

To fix the warning introduced before:

2024-07-23T07:25:38.9243161Z /home/runner/work/blazingmq/blazingmq/src/groups/mqb/mqbstat/mqbstat_jsonprinter.h:51:7: warning: ‘BloombergLP::mqbstat::JsonPrinter’ has a field ‘BloombergLP::mqbstat::JsonPrinter::d_impl_mp’ whose type uses the anonymous namespace [-Wsubobject-linkage]
2024-07-23T07:25:38.9245536Z    51 | class JsonPrinter {
  • Remove forward declaration from the unnamed namespace in the header
  • Make JsonPrinterImpl a private forward declared type to JsonPrinter
  • Extract static methods from JsonPrinterImpl to ConversionUtils placed in the unnamed namespace
  • Reduce the build log from 8000 lines to 7636 by getting rid of this warning

@678098 678098 requested a review from a team as a code owner July 23, 2024 11:19
@dorjesinpo dorjesinpo merged commit e1621ff into bloomberg:main Jul 23, 2024
25 checks passed
@678098 678098 deleted the 240723_fix_warnings branch July 23, 2024 13:54
alexander-e1off pushed a commit to alexander-e1off/blazingmq that referenced this pull request Oct 24, 2024
alexander-e1off pushed a commit to alexander-e1off/blazingmq that referenced this pull request Oct 24, 2024
alexander-e1off pushed a commit to alexander-e1off/blazingmq that referenced this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants