Isolated declarations error messages

[dragomirtitian]

Improved errors.

[h-joo]

LGTM

[h-joo]

In this sentence, it might be confusing in the first glance whether the "with" is connected to symbols or the whole sentence. I guess "With --isolatedDeclarations, enum member ..." might be better, but for consistency, maybe it's okay.

[dragomirtitian]

I did worry about it as well. I'm not sure how to phrase it and make it consistent though

[h-joo]

... supported with --isolatedDeclarations for consistency?

[dragomirtitian]

Yes. Will change.

[h-joo]

Also, this PR does not seem to build.

src/compiler/utilities.ts:8628:62 - error TS2345: Argument of type '{ target: { dependencies: "module"[]; computeValue: (compilerOptions: Pick<CompilerOptions, "types" | "lib" | "jsx" | "all" | "allowImportingTsExtensions" | "allowJs" | "allowNonTsExtensions" | ... 120 more ... | "useDefineForClassFields">) => ScriptTarget; }; ... 23 more ...; useUnknownInCatchVariables: { ...; }; }' is not assignable to parameter of type '{ types: { dependencies: ("types" | "lib" | "jsx" | "all" | "allowImportingTsExtensions" | "allowJs" | "allowNonTsExtensions" | "allowArbitraryExtensions" | "allowSyntheticDefaultImports" | ... 118 more ... | "useDefineForClassFields")[]; computeValue: (compilerOptions: Pick<...>) => string[]; }; ... 126 more ...; u...'.
  Type '{ target: { dependencies: "module"[]; computeValue: (compilerOptions: Pick<CompilerOptions, "types" | "lib" | "jsx" | "all" | "allowImportingTsExtensions" | "allowJs" | "allowNonTsExtensions" | ... 120 more ... | "useDefineForClassFields">) => ScriptTarget; }; ... 23 more ...; useUnknownInCatchVariables: { ...; }; }' is missing the following properties from type '{ types: { dependencies: ("types" | "lib" | "jsx" | "all" | "allowImportingTsExtensions" | "allowJs" | "allowNonTsExtensions" | "allowArbitraryExtensions" | "allowSyntheticDefaultImports" | ... 118 more ... | "useDefineForClassFields")[]; computeValue: (compilerOptions: Pick<...>) => string[]; }; ... 126 more ...; u...': types, lib, jsx, all, and 99 more.

8628 export const computedOptions = createComputedCompilerOptions({
                                                                  ~
8629     target: {
     ~~~~~~~~~~~~~
 ... 
8846     },
     ~~~~~~
8847 });
     ~

src/compiler/commandLineParser.ts:2522:17 - error TS2322: Type 'string | number | boolean | TsConfigSourceFile | string[] | MapLike<string[]> | PluginImport[]' is not assignable to type 'CompilerOptionsValue'.
  Type 'TsConfigSourceFile' is not assignable to type 'CompilerOptionsValue'.
    Type 'TsConfigSourceFile' is not assignable to type 'MapLike<string[]>'.
      Index signature for type 'string' is missing in type 'TsConfigSourceFile'.

2522                 impliedCompilerOptions[option] = computedOptions[option as keyof typeof computedOptions].computeValue(configParseResult.options);
                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


Found 2 errors.

Error in build-tsc in 4.6s