Isolated declarations new method #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragomirtitian
force-pushed
the
isolated-declarations-new
branch
2 times, most recently
from
514d238 to
d78232c
Compare
h-joo
approved these changes
Nov 27, 2023
|
@h-joo i now use one of TS's methods to decide the final identifier. That method will erase original position info where I initially just reused the source node as much as possible (and this preserved more of the source info) |
Thank you for the explanation. |
Signed-off-by: Titian Cernicova-Dragomir <[email protected]>
dragomirtitian
force-pushed
the
isolated-declarations-new
branch
from
d78232c to
1d882e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.