Minimize API surface. #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Titian Cernicova-Dragomir <[email protected]>
dragomirtitian
force-pushed
the
isolated-declarations-api
branch
from
cce3148 to
93912bb
Compare
h-joo
approved these changes
Nov 22, 2023
There was a problem hiding this comment.
reminder: I think we still need to rename these files.
There was a problem hiding this comment.
Yeah. Wil get to that one soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify API for isolated declarations. Turns out some of the things we were doing were not strictly necessary after we removed support for reference directives.