Introduce ScanScope, a more flexible way to define what to scan. #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zach-klippenstein
requested review from
jamesmosley55,
pyricau and
a team
as code owners
zach-klippenstein
force-pushed
the
zachklipp/scanscope
branch
from
6050413 to
d9491c7
Compare
This was referenced Aug 31, 2020
Merged
pyricau
reviewed
Sep 1, 2020
| @@ -40,69 +38,70 @@ public object Radiography { | |||
| @JvmStatic | |||
| @JvmOverloads | |||
| public fun scan( | |||
| rootView: View? = null, | |||
| scanScope: ScanScope = AllWindowsScope, | |||
pyricau
reviewed
Sep 1, 2020
| @ExperimentalRadiographyComposeApi | ||
| @JvmStatic | ||
| @JvmOverloads | ||
| fun composeTestTagScope( |
There was a problem hiding this comment.
Might want to explain what a TestTag is and even link to the doc. https://developer.android.com/reference/kotlin/androidx/compose/ui/platform/package-summary#(androidx.compose.ui.Modifier).testTag(kotlin.String)
Applies a tag to allow modified element to be found in tests.
It's not clear how this relates to Radiography.
There was a problem hiding this comment.
Good catch, I linked to the docs in the ViewFilter for test tags, but forgot to do so here.
pyricau
approved these changes
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #69.
Closes #58.
FocusedWindowViewFilteris nowFocusedWindowScope.SlotTable.scan()is gone.