SL:70 Change logic for calculating server load #445
Conversation
git-lama
force-pushed
the
server_load
branch
3 times, most recently
from
252742a to
54b2a85
Compare
|
Hi, wouldn't it be even wiser to use this metric : |
resolve review comments
git-lama
force-pushed
the
server_load
branch
from
f02f47c to
49f6612
Compare
| * `LOAD_MIN_USER_COUNT`: Minimum user count of a meeting, used for calculating server load. Defaults to 15. | ||
| * `LOAD_JOIN_BUFFER_TIME`: The time(in minutes) until the `LOAD_MIN_USER_COUNT` will be used for calculating server load. Defaults to 15. |
There was a problem hiding this comment.
Hmm. The wording here is confusing or backwards - it implies that LOAD_MIN_USER_COUNT is not applied for the first 15 minutes, but then is applied afterwards.
I'm not sure the best way to word these help messages would be, maybe it would help to reverse the order, something like this?
| * `LOAD_MIN_USER_COUNT`: Minimum user count of a meeting, used for calculating server load. Defaults to 15. | |
| * `LOAD_JOIN_BUFFER_TIME`: The time(in minutes) until the `LOAD_MIN_USER_COUNT` will be used for calculating server load. Defaults to 15. | |
| * `LOAD_JOIN_BUFFER_TIME`: During the buffer time after a meeting starts, the server load calculation accounts a boosted load value to the meeting to compensate for people who have not yet joined. Values is in minutes, defaults to 15. | |
| * `LOAD_MIN_USER_COUNT`: The minimum number of people to assume a meeting will have during the join buffer time. Defaults to 15. |
There was a problem hiding this comment.
hmm, may be @jfederico can help
There was a problem hiding this comment.
@kepstin I would agree with you. I didn't get it with the readme explanation and had the need to look into the code.
|
Code looks ready to merge, I just want to make sure the documentation is clear so that users will understand how the new environment variables work. |
|
If I read the pull request correctly you don't use the load_multiplier anymore. |
* scalelite/v1.0-stable: SL-99: Fixed issue processing BBB23 recordings and mounted on NFS (blindsidenetworks#484) Add bug fix for issue blindsidenetworks#471 (blindsidenetworks#472) use load multiplier to calculate load SL-86: added new variables to README (blindsidenetworks#465) SL-91: scaelite-nginx has an error on start (blindsidenetworks#463) Change logic for calculating server load (blindsidenetworks#445)
Change the algorithm for calculating the load on every server:
New Logic: Server load calculation is now based on number of users, and the SL gives every meeting an assignment of 15 users when it starts, and then post that uses max(actual number of users, 15).