Check if field exists within segment's visitStoredFields callback #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there isn't an entry for a field within fieldsMap, fieldID is set to -1 causing the following array lookup to panic .. ``` panic: runtime error: index out of range [-1] goroutine 205 [running]: github.com/blevesearch/zapx/v15.mergeStoredAndRemap.func2(0xc0076e2cf0, 0x27, 0x74, 0xc005d7cd3c, 0x15, 0x336b8, 0x0, 0x0, 0x0, 0x1) /builds/gopath/pkg/mod/github.com/blevesearch/zapx/[email protected]/merge.go:722 +0x57b github.com/blevesearch/zapx/v15.(*SegmentBase).visitStoredFields(0xc000770800, 0xc001c14000, 0x5d7, 0xc002777698, 0x2df, 0x0) /builds/gopath/pkg/mod/github.com/blevesearch/zapx/[email protected]/segment.go:382 +0x39c ``` Ref: blevesearch/bleve#1648
abhinavdangeti
force-pushed
the
bleve#1648
branch
from
c9d12e1 to
e6553f5
Compare
abhinavdangeti
changed the title
abhinavdangeti
requested review from
Thejas-bhat,
metonymic-smokey and
moshaad7
Thejas-bhat
approved these changes
Apr 12, 2023
abhinavdangeti
added a commit
that referenced
this pull request
May 16, 2023
#105) If there isn't an entry for a field within fieldsMap, fieldID is set to -1 causing the following array lookup to panic .. ``` panic: runtime error: index out of range [-1] goroutine 205 [running]: github.com/blevesearch/zapx/v15.mergeStoredAndRemap.func2(0xc0076e2cf0, 0x27, 0x74, 0xc005d7cd3c, 0x15, 0x336b8, 0x0, 0x0, 0x0, 0x1) /builds/gopath/pkg/mod/github.com/blevesearch/zapx/[email protected]/merge.go:722 +0x57b github.com/blevesearch/zapx/v15.(*SegmentBase).visitStoredFields(0xc000770800, 0xc001c14000, 0x5d7, 0xc002777698, 0x2df, 0x0) /builds/gopath/pkg/mod/github.com/blevesearch/zapx/[email protected]/segment.go:382 +0x39c ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there isn't an entry for a field within fieldsMap, fieldID
is set to -1 causing the following array lookup to panic ..
Ref: blevesearch/bleve#1648