Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MB-61889: Address corner case with ivf_nprobe_pct #34

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

abhinavdangeti
Copy link
Member

@abhinavdangeti abhinavdangeti commented Sep 3, 2024

  • With certain cluster counts within centroid indexes, a very
    low value for ivf_nprobe_pct can cause nprobe to be rounded
    down to 0, which would result in this error ..
Error in virtual void faiss::IndexIVF::search(faiss::idx_t, const float*, faiss::idx_t, float*,
faiss::idx_t*, const faiss::SearchParameters*) const at /home/couchbase/.../faiss/faiss/IndexIVF.cpp:310:
    Error: 'nprobe > 0' failed
  • In this event, we should be rounding up nprobe to 1 instead.

+ With certain cluster counts within centroid indexes, a very
  low value for ivf_nprobe_pct can cause nprobe to be rounded
  down to 0, which would result in this error ..
```
Error in virtual void faiss::IndexIVF::search(
faiss::idx_t, const float*, faiss::idx_t, float*,
faiss::idx_t*, const faiss::SearchParameters*) const at
/home/couchbase/.../faiss/faiss/IndexIVF.cpp:310:
Error: 'nprobe > 0' failed
```
+ In this event, we should be rounding up nprobe to 1 instead.
search_params.go Outdated Show resolved Hide resolved
moshaad7
moshaad7 previously approved these changes Sep 4, 2024
@abhinavdangeti abhinavdangeti merged commit 1bb080b into master Sep 4, 2024
@abhinavdangeti abhinavdangeti deleted the nprobeMin branch September 4, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants