When using cjk analyzer with output_unigram, an unigram before Japanese punctuation is not indexed
#1724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhinavdangeti
requested review from
abhinavdangeti,
metonymic-smokey,
moshaad7 and
Thejas-bhat
abhinavdangeti
approved these changes
Nov 16, 2022
|
Thanks for this contribution @kaakaa . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When I do indexing and searching Japanese text with cjk analyzer with
output_unigramconfig, the word before Japanese punctuation characters (e.g.:、,。) cannot be searched. For example, I got no results with the search queryちはfrom sentence ofこんにちは、世界, but I got a result with the search queryちはfrom sentence ofこんにちは世界.I look into this, and I found that CJKBigramFilter doesn't flush unigram before punctuations correctly. This PR fixed it.
Sample code to reproduce this issue is here:
https://gist.github.com/kaakaa/ca8c20821ef610b098851f487eb61ea5