MB-47476: JSON marshalers cannot work on 0xff (HighTerm)
#1608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using unicode/utf8's MaxRune as the `HighTerm` for sort while missing values.
abhinavdangeti
changed the title
0x7f0xff (HighTerm)
mschoch
reviewed
Jul 26, 2021
search/sort.go
Outdated
|
|
||
| "github.com/blevesearch/bleve/v2/geo" | ||
| "github.com/blevesearch/bleve/v2/numeric" | ||
| ) | ||
|
|
||
| var HighTerm = strings.Repeat(string([]byte{0xff}), 10) | ||
| var HighTerm = string(utf8.MaxRune) |
There was a problem hiding this comment.
one thought is that we repeat the max rune 3x, that way get 12 bytes (approximately as long as the byte sequence we had before)
len(utf8.MaxRune) = 4 bytes
sreekanth-cb
approved these changes
Jul 28, 2021
abhinavdangeti
added a commit
that referenced
this pull request
Jul 28, 2021
* MB-47476: JSON marshalers cannot work on `0xff` (HighTerm)
Using unicode/utf8's MaxRune as the `HighTerm` for sort while
missing values.
* Increase HighTerm length to > 10bytes
len(utf8.MaxRune) = 4 bytes
abhinavdangeti
added a commit
that referenced
this pull request
Jul 28, 2021
(#1608) * MB-47476: JSON marshalers cannot work on `0xff` (HighTerm) Using unicode/utf8's MaxRune as the `HighTerm` for sort while missing values. * Increase HighTerm length to > 10bytes len(utf8.MaxRune) = 4 bytes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using unicode/utf8's MaxRune as the
HighTermfor sort whilemissing values.