update analysis.TokenFrequency to use options #1522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously it used boolean, and future changes would require additional booleans. using options directly keeps the function signatures cleaner.
abhinavdangeti
approved these changes
Dec 16, 2020
mschoch
added a commit
that referenced
this pull request
Dec 16, 2020
* use the moved indexing options * update analysis.TokenFrequency to use options (#1522) * update analysis.TokenFrequency to use options previously it used boolean, and future changes would require additional booleans. using options directly keeps the function signatures cleaner. * update to latest apis
mschoch
added a commit
that referenced
this pull request
Jan 12, 2021
* refactor to remove circular deps * reduce index and segment API surface area * update Advanced() method (#1509) * relocate store pkg inside upsidedown (#1510) * remove Advanced() method from scorch (#1511) * remove use of dump methods from index reader (#1516) * remove remaining blevex imports (#1520) * update analysis.TokenFrequency to use options (#1522) * switch default index to scorch with latest zap (#1528) * MatchOperator should be that type instead of int (#1410) Co-authored-by: Sreekanth Sivasankaran <[email protected]> Co-authored-by: Mario de Frutos Dieguez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously it used boolean, and future changes would
require additional booleans. using options directly
keeps the function signatures cleaner.