Handle numeric fields other than float64 in processProperty #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assert non-float types to type float64, then re-process. Fixes #106
|
I'm starting to be persuaded that this is the right way to go for now. We would need to test and document that integer precision is limited by conversion through float64. But that this is acceptable for many use cases, so we should not let that block integrating the feature. Fixing this correctly can be put off to bleve2, etc. |
|
I need to index a struct with int fields so I just tried this out and it works great for my needs. Thanks @pdf |
|
@mschoch - would really love to get this merged. Just my +1 :-) |
mschoch
added a commit
that referenced
this pull request
Feb 5, 2016
Handle numeric fields other than float64 in processProperty
abhinavdangeti
added a commit
that referenced
this pull request
Feb 21, 2023
To include: * 67addef Callum Jones | Fixed 64-bit alignment panic in chunkedContentCoder on 32-bit platforms. (#148)
abhinavdangeti
added a commit
that referenced
this pull request
Feb 21, 2023
To include: * 67addef Callum Jones | Fixed 64-bit alignment panic in chunkedContentCoder on 32-bit platforms. (#148)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assert non-float types to type float64, then re-process.