Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon deferring; match all SVG tags #244

Merged
merged 3 commits into from
Jul 26, 2024
Merged

Conversation

@royduin
Copy link
Contributor Author

royduin commented Jul 25, 2024

Should we still support Laravel 8? EOL for a while now...

@royduin
Copy link
Contributor Author

royduin commented Jul 25, 2024

cc @indykoning @pionl @AEM5299

src/Svg.php Outdated Show resolved Hide resolved
@driesvints
Copy link
Member

@royduin no we can remove it but can we do that in a separate PR? Can you send one in? Thanks 🙏

@royduin
Copy link
Contributor Author

royduin commented Jul 25, 2024

Changed it to the Str class instead of the str() helper, also replaced toString() with __toString() which also makes it Laravel 8 compatible. No need to drop Laravel 8 support yet with these changes.

@driesvints driesvints merged commit 99783fe into blade-ui-kit:1.x Jul 26, 2024
13 checks passed
@driesvints
Copy link
Member

Awesome, thanks @royduin

@royduin royduin deleted the patch-1 branch July 26, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants