Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace complex pool with mutex pool #92

Merged
merged 7 commits into from
Feb 13, 2020
Merged

Replace complex pool with mutex pool #92

merged 7 commits into from
Feb 13, 2020

Conversation

jonhoo
Copy link
Contributor

@jonhoo jonhoo commented Feb 11, 2020

Fixes #65

@jonhoo
Copy link
Contributor Author

jonhoo commented Feb 11, 2020

Hmm, the test on 8.0 seems unrelated to this change @blackbeam ?

@jonhoo
Copy link
Contributor Author

jonhoo commented Feb 11, 2020

Anecdotally, this eliminates the connection leaking I was seeing that was causing #65.

@jonhoo jonhoo marked this pull request as ready for review February 11, 2020 15:41
@jonhoo jonhoo requested a review from blackbeam February 11, 2020 16:08
@jonhoo
Copy link
Contributor Author

jonhoo commented Feb 11, 2020

I discovered a race, so hold off on merging this for a little bit.

@jonhoo
Copy link
Contributor Author

jonhoo commented Feb 11, 2020

Okay, I think that last commit fixed it, and that this is now ready.

@jonhoo
Copy link
Contributor Author

jonhoo commented Feb 11, 2020

Bah, apparently not -- will dig more.

@jonhoo
Cleaner exit when the user does not wait
d48cb8c 
We used to panic in this case, which was probably not the right thing to do.
@jonhoo
Copy link
Contributor Author

jonhoo commented Feb 11, 2020

Phew, okay, that should do it!

@jonhoo jonhoo mentioned this pull request Feb 13, 2020
Closed
@blackbeam blackbeam merged commit 8021666 into blackbeam:master Feb 13, 2020
@jonhoo jonhoo deleted the simplified-pool branch March 2, 2020 18:17
@jonhoo
Copy link
Contributor Author

jonhoo commented Mar 2, 2020

@blackbeam Can we do a point release with this change?

@blackbeam
Copy link
Owner

blackbeam commented Mar 2, 2020 •
edited
Loading

@jonhoo, I'll publish master as v0.22.0.
Please tell me if you need a more precise release with only this change.

UPD: v0.22.0.

@jonhoo
Copy link
Contributor Author

jonhoo commented Mar 2, 2020

No, a major release is fine too :)

@jonhoo jonhoo mentioned this pull request Mar 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blackbeam blackbeam Awaiting requested review from blackbeam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pool::get_conn hangs under contention
2 participants
@jonhoo @blackbeam