Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Add ability to specify modal size of small, medium, or large. #767

Merged
merged 7 commits into from
Jun 9, 2017

Conversation

Blackbaud-AdamHickey
Copy link
Contributor

Adding small, medium, and large configurations for the modal. #489

@codecov-io
Copy link

codecov-io commented Jun 7, 2017

Codecov Report

Merging #767 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #767      +/-   ##
==========================================
+ Coverage   99.94%   99.94%   +<.01%     
==========================================
  Files         286      286              
  Lines        5136     5145       +9     
  Branches      598      602       +4     
==========================================
+ Hits         5133     5142       +9     
  Misses          3        3
Impacted Files Coverage Δ
src/modules/modal/modal.service.ts 100% <100%> (ø) ⬆️
src/modules/modal/modal-configuration.ts 100% <100%> (ø) ⬆️
src/modules/modal/modal.component.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b5248e...480d62d. Read the comment docs.

@Blackbaud-PatrickOFriel
Copy link
Contributor

Looks good pending @Blackbaud-ToddRoberts review

Copy link
Contributor

@Blackbaud-ToddRoberts Blackbaud-ToddRoberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Which team did the request come from? I want to see if their designer has guidelines for when to use which size.

@Blackbaud-PatrickOFriel Blackbaud-PatrickOFriel merged commit 73da48f into master Jun 9, 2017
@Blackbaud-PatrickOFriel Blackbaud-PatrickOFriel deleted the modal-size branch June 16, 2017 15:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants