-
Notifications
You must be signed in to change notification settings - Fork 65
added changelog for v. 2.25.0. Updated core #1990
Conversation
CHANGELOG.md
Outdated
|
||
- Updated version of skyux-core. | ||
- Added keyboard controls for resizing flyouts. [1760](https://github.com/blackbaud/skyux2/pull/1760) | ||
- Switched from using /deep/ to using ::ng-deep. [1955](https://github.com/blackbaud/skyux2/pull/1955) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this start with Added/Updated/Fixed ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Updated all shadow piercing combinators to use Angular's proprietary ::ng-deep
."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Don't forget #1929 - Updated flyouts to close whenever user clicks outside of a flyout. |
Oh yes! Sorry, I skipped over it at first so I could go back and check what it was. Didn't want to put "make flyouts great again 😜 |
CHANGELOG.md
Outdated
|
||
- Updated version of skyux-core. | ||
- Added keyboard controls for resizing flyouts. [1760](https://github.com/blackbaud/skyux2/pull/1760) | ||
- Updated components using `/deep/` to instead use `::ng-deep`. [1955](https://github.com/blackbaud/skyux2/pull/1955) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we give some more "color" to this change? "Updated all shadow piercing combinators to use Angular's proprietary ::ng-deep."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
CHANGELOG.md
Outdated
- Updated all shadow piercing combinators to use Angular's proprietary `::ng-deep`. [1955](https://github.com/blackbaud/skyux2/pull/1955) | ||
- Updated flyouts to close whenever user clicks outside of a flyout. [1929](https://github.com/blackbaud/skyux2/pull/1929) | ||
- Updated modal content panes to be focusable for accessible scrolling. [#1809](https://github.com/blackbaud/skyux2/pull/1809) | ||
- Added keyboard controls for reordering tiles. [#1815](https://github.com/blackbaud/skyux2/pull/1815) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might want to pool together all the "added"'s. I think it goes 1. Added 2. Updated 3. Fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
No description provided.