Skip to content
This repository was archived by the owner on Dec 8, 2022. It is now read-only.

added changelog for v. 2.25.0. Updated core #1990

Merged
merged 5 commits into from
Sep 17, 2018

Conversation

blackbaud-conorwright
Copy link
Contributor

No description provided.

CHANGELOG.md Outdated

- Updated version of skyux-core.
- Added keyboard controls for resizing flyouts. [1760](https://github.com/blackbaud/skyux2/pull/1760)
- Switched from using /deep/ to using ::ng-deep. [1955](https://github.com/blackbaud/skyux2/pull/1955)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this start with Added/Updated/Fixed ?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Updated all shadow piercing combinators to use Angular's proprietary ::ng-deep."

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@Blackbaud-AlexKingman
Copy link
Contributor

Don't forget #1929 - Updated flyouts to close whenever user clicks outside of a flyout.

@blackbaud-conorwright
Copy link
Contributor Author

Oh yes! Sorry, I skipped over it at first so I could go back and check what it was. Didn't want to put "make flyouts great again 😜

CHANGELOG.md Outdated

- Updated version of skyux-core.
- Added keyboard controls for resizing flyouts. [1760](https://github.com/blackbaud/skyux2/pull/1760)
- Updated components using `/deep/` to instead use `::ng-deep`. [1955](https://github.com/blackbaud/skyux2/pull/1955)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we give some more "color" to this change? "Updated all shadow piercing combinators to use Angular's proprietary ::ng-deep."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

CHANGELOG.md Outdated
- Updated all shadow piercing combinators to use Angular's proprietary `::ng-deep`. [1955](https://github.com/blackbaud/skyux2/pull/1955)
- Updated flyouts to close whenever user clicks outside of a flyout. [1929](https://github.com/blackbaud/skyux2/pull/1929)
- Updated modal content panes to be focusable for accessible scrolling. [#1809](https://github.com/blackbaud/skyux2/pull/1809)
- Added keyboard controls for reordering tiles. [#1815](https://github.com/blackbaud/skyux2/pull/1815)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to pool together all the "added"'s. I think it goes 1. Added 2. Updated 3. Fixed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor

@Blackbaud-AlexKingman Blackbaud-AlexKingman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@blackbaud-conorwright blackbaud-conorwright merged commit fb53de4 into master Sep 17, 2018
@blackbaud-conorwright blackbaud-conorwright deleted the changelog-2.25.0 branch September 17, 2018 20:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants