-
Notifications
You must be signed in to change notification settings - Fork 65
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1896 +/- ##
======================================
Coverage 100% 100%
======================================
Files 415 415
Lines 8750 8752 +2
Branches 1292 1292
======================================
+ Hits 8750 8752 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@blackbaud-conorwright could you possibly add an example of this use case into the demo component? It is probably valuable to show this new style in the demo.
Sorry I missed moving that over 😛 |
Issue to document |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@blackbaud-conorwright we need to update where the demo anchor tag points to.
@@ -24,4 +24,17 @@ | |||
Open a list with filters saved in the web view | |||
</sky-action-button-details> | |||
</sky-action-button> | |||
|
|||
<sky-action-button | |||
url="https://host.nxt.blackbaud.com/skyux2/?component=SkyIconDemoComponent"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This url will not work on the documentation site. We need to change this to something that will work from that site
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yeah, good catch. I'll switch it to be relative or link somewhere more generic
…ux2 into contrib-action-button-link
moved changes from #1886 by @Remulus2006 to avoid history issues
Resolves: #1465