Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Contrib > Action button link #1896

Merged
merged 12 commits into from
Aug 20, 2018
Merged

Conversation

blackbaud-conorwright
Copy link
Contributor

@blackbaud-conorwright blackbaud-conorwright commented Aug 13, 2018

moved changes from #1886 by @Remulus2006 to avoid history issues

Resolves: #1465

@codecov-io
Copy link

codecov-io commented Aug 13, 2018

Codecov Report

Merging #1896 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1896   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files         415     415           
  Lines        8750    8752    +2     
  Branches     1292    1292           
======================================
+ Hits         8750    8752    +2
Impacted Files Coverage Δ
src/modules/action-button/action-button.module.ts 100% <100%> (ø) ⬆️
...ules/action-button/action-button-icon.component.ts 100% <100%> (ø) ⬆️
...c/modules/action-button/action-button.component.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7fd445...bd76b9a. Read the comment docs.

Copy link
Member

@Blackbaud-TrevorBurch Blackbaud-TrevorBurch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blackbaud-conorwright could you possibly add an example of this use case into the demo component? It is probably valuable to show this new style in the demo.

@blackbaud-conorwright
Copy link
Contributor Author

Sorry I missed moving that over 😛
Should be there now @Blackbaud-TrevorBurch

@blackbaud-johnly
Copy link
Contributor

Issue to document url input property: #1902.

Copy link
Member

@Blackbaud-TrevorBurch Blackbaud-TrevorBurch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blackbaud-conorwright we need to update where the demo anchor tag points to.

@@ -24,4 +24,17 @@
Open a list with filters saved in the web view
</sky-action-button-details>
</sky-action-button>

<sky-action-button
url="https://host.nxt.blackbaud.com/skyux2/?component=SkyIconDemoComponent">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This url will not work on the documentation site. We need to change this to something that will work from that site

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah, good catch. I'll switch it to be relative or link somewhere more generic

@blackbaud-conorwright blackbaud-conorwright merged commit 08722d9 into master Aug 20, 2018
@blackbaud-conorwright blackbaud-conorwright deleted the contrib-action-button-link branch August 20, 2018 17:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants