Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

aria associated tab buttons with tab panels #1786

Merged
merged 7 commits into from
Jul 3, 2018

Conversation

blackbaud-conorwright
Copy link
Contributor

Added aria associations between tab buttons and tab panels
Resolves: #1380

@Blackbaud-SteveBrush Blackbaud-SteveBrush self-assigned this Jul 2, 2018
@codecov-io
Copy link

codecov-io commented Jul 2, 2018

Codecov Report

Merging #1786 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1786      +/-   ##
==========================================
+ Coverage   99.98%   99.98%   +<.01%     
==========================================
  Files         410      410              
  Lines        8556     8562       +6     
  Branches     1256     1257       +1     
==========================================
+ Hits         8555     8561       +6     
  Misses          1        1
Impacted Files Coverage Δ
src/modules/tabs/tabset.component.ts 100% <100%> (ø) ⬆️
src/modules/tabs/tab.component.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0f2cb7...ab0c286. Read the comment docs.

@Blackbaud-SteveBrush Blackbaud-SteveBrush dismissed their stale review July 2, 2018 19:03

Visual tests failed

@Blackbaud-SteveBrush Blackbaud-SteveBrush merged commit 5cbb63c into master Jul 3, 2018
@Blackbaud-SteveBrush Blackbaud-SteveBrush deleted the fix-tab-panel-aria-association branch July 3, 2018 18:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants