Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

URL validation module #1334

Merged
merged 2 commits into from
Dec 1, 2017
Merged

URL validation module #1334

merged 2 commits into from
Dec 1, 2017

Conversation

Blackbaud-SteveBrush
Copy link
Member

@Blackbaud-SteveBrush Blackbaud-SteveBrush commented Dec 1, 2017

We'll consider combining all validators into a single "Validation" module based on @Blackbaud-JeffDye's work, here: #1248

Addresses: #1232

Copy link
Contributor

@Blackbaud-JeffDye Blackbaud-JeffDye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@codecov-io
Copy link

codecov-io commented Dec 1, 2017

Codecov Report

Merging #1334 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1334   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files         362     364    +2     
  Lines        6704    6723   +19     
  Branches      863     865    +2     
======================================
+ Hits         6704    6723   +19
Impacted Files Coverage Δ
...modules/url-validation/url-validation.directive.ts 100% <100%> (ø)
...rc/modules/url-validation/url-validation.module.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de8508a...a5a7a76. Read the comment docs.

@Blackbaud-SteveBrush Blackbaud-SteveBrush merged commit 77caf12 into master Dec 1, 2017
@Blackbaud-SteveBrush Blackbaud-SteveBrush deleted the url-validation branch December 1, 2017 17:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants