This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Card action bar still visable after hiding with *ngIf #1421
Assignees
Labels
Comments
blackbaud-conorwright
added a commit
to blackbaud-conorwright/skyux2
that referenced
this issue
Mar 7, 2018
blackbaud-conorwright
added a commit
that referenced
this issue
Jun 6, 2018
* Resolving Card action bar still visable after hiding with *ngIf #1421 * Addressed PR style comments * initial setup for progress-indicator based on Christi Schneider's branch * implemented the progress indicator component tests * Finished the progress indicator visual tests
blackbaud-conorwright
added a commit
that referenced
this issue
Jun 8, 2018
* Resolving Card action bar still visable after hiding with *ngIf #1421 * Addressed PR style comments * updated demo with clear button * added datepicker support for undefined values
blackbaud-conorwright
pushed a commit
that referenced
this issue
Sep 6, 2018
* Resolving Card action bar still visable after hiding with *ngIf #1421 * Addressed PR style comments * added reactive demo. started radio-group * refined the group component * trimmed copy of material * added unique selection service * added module references * removed excess * removed label pos * Base functionality complete. Few issues remaining * Added initial value selection * fixed unit test and prop names * renamed unique selection service * made input public to focus on triggers * fixed reference issue * addeed reactive form to radio vistests. removed ngModel from radio btns * updated for pr comments * fixed tslint issue * removed unused form submit in demo * added fixtures. Added radio unit testing * addressed pr comments * fixed ts lint issue * Prepared branch * Updated visual tests * Fixed build issue * Fixed a11y bug * Fixed a11y * Fixed a11y failures * put comments back in * fixed aria issue with visual tests and regenerated for labelling * fixed tslint issues
blackbaud-conorwright
added a commit
that referenced
this issue
Sep 25, 2018
* Resolving Card action bar still visable after hiding with *ngIf #1421 * Addressed PR style comments * added missing aria labels to sky-repeater and tests * swapped section role to be region * ignored blur on colorinput * changed section to div and removed role * removed h1 tag so users can choose their own header if at all * fixed line-height shift on repeater title * fixed to use color variable
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Expected behavior
The entire action section should be removed if an *ngIf expression on
sky-card-actionsis false.Actual behavior
The action bar remains visible until another change detection occurs.
Steps to reproduce
Show actionand see that only the button was hidden.Show title.The text was updated successfully, but these errors were encountered: