Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Changed detectChanges() to markForCheck() to avoid ViewDestroyedError #21

Merged
merged 2 commits into from
Apr 23, 2019
Merged

Changed detectChanges() to markForCheck() to avoid ViewDestroyedError #21

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
acb98bc
Removed setTimeout to avoid ViewDestroyedError
Blackbaud-AlexKingman Apr 23, 2019
26596ee
changed to using markForCheck()
Blackbaud-AlexKingman Apr 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/app/public/modules/tabs/tabset.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ export class SkyTabsetComponent
setTimeout(() => {
this.adapterService.detectOverflow();
this.updateDisplayMode(this.adapterService.currentOverflow);
this.changeRef.detectChanges();
this.changeRef.markForCheck();
}, 0);
}

Expand All @@ -163,6 +163,6 @@ export class SkyTabsetComponent

private updateDisplayMode(currentOverflow: boolean) {
this.tabDisplayMode = currentOverflow ? 'dropdown' : 'tabs';
this.changeRef.detectChanges();
this.changeRef.markForCheck();
}
}