-
Notifications
You must be signed in to change notification settings - Fork 5
Added debounce time to autocomplate (and lookup) #8
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
|
||
// The search method should not execute at this time. | ||
tick(10); | ||
expect(spy).not.toHaveBeenCalled(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I notice you aren't using fixture.detectChanges()
in the tick(10)
scenario, but you do use in in thetick(400)
scenario. Does this impact the test? Just trying to make sure we're comparing apples and apples and not getting a false positive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good eye. I didn't put a detectChanges
there because there wasn't any data binding taking place. But I threw one in there just in case.
Codecov Report
@@ Coverage Diff @@
## master #8 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 13 13
Lines 613 619 +6
Branches 107 108 +1
=====================================
+ Hits 613 619 +6
Continue to review full report at Codecov.
|
Created blackbaud/skyux2#2172 to document the |
Addresses: https://github.com/blackbaud/skyux-lookup/issues/7