Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Added debounce time to autocomplate (and lookup) #8

Merged
merged 3 commits into from
Nov 14, 2018

Conversation

Blackbaud-SteveBrush
Copy link
Member

Copy link
Contributor

@blackbaud-conorwright blackbaud-conorwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me


// The search method should not execute at this time.
tick(10);
expect(spy).not.toHaveBeenCalled();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice you aren't using fixture.detectChanges() in the tick(10) scenario, but you do use in in thetick(400) scenario. Does this impact the test? Just trying to make sure we're comparing apples and apples and not getting a false positive.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good eye. I didn't put a detectChanges there because there wasn't any data binding taking place. But I threw one in there just in case.

@codecov-io
Copy link

codecov-io commented Nov 14, 2018

Codecov Report

Merging #8 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #8   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          13     13           
  Lines         613    619    +6     
  Branches      107    108    +1     
=====================================
+ Hits          613    619    +6
Impacted Files Coverage Δ
...blic/modules/lookup/lookup-autocomplete-adapter.ts 100% <100%> (ø) ⬆️
...lic/modules/autocomplete/autocomplete.component.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef4e53c...8a4a9c5. Read the comment docs.

@blackbaud-johnly
Copy link
Contributor

Created blackbaud/skyux2#2172 to document the debounceTime input.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants