This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
make it so picker does not take up full width #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blackbaud-ToddRoberts
requested a review
from Blackbaud-AlexKingman
as a code owner
previous approach failed under some conditions
Codecov Report
@@ Coverage Diff @@
## master #46 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 26 26
Lines 1315 1315
Branches 200 200
=====================================
Hits 1315 1315Continue to review full report at Codecov.
|
Blackbaud-ToddRoberts
changed the title
|
holding to review with @Blackbaud-AdamFunderburk |
Blackbaud-ToddRoberts
changed the title
|
Looks like you'll need to delete a couple visual test baselines to get those tests to pass. |
src/app/public/modules/date-range-picker/date-range-picker.component.scss
Show resolved
Hide resolved
Blackbaud-AlexKingman
previously approved these changes
May 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The picker should stay the same width regardless of whether the selection causes other date fields to appear.
Addresses #47