This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Fixed colorpicker to not show content when the color has transparency #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blackbaud-TrevorBurch
requested review from
Blackbaud-AlexKingman and
Blackbaud-SteveBrush
as code owners
Codecov Report
@@ Coverage Diff @@
## master #15 +/- ##
=======================================
+ Coverage 99.39% 100% +0.6%
=======================================
Files 10 10
Lines 497 496 -1
Branches 54 54
=======================================
+ Hits 494 496 +2
+ Misses 3 0 -3
Continue to review full report at Codecov.
|
| @@ -247,7 +247,7 @@ export class SkyColorpickerInputDirective | |||
| this.skyColorpickerInput.setColorFromString(output); | |||
|
|
|||
| this.renderer.setElementStyle(element, 'background-color', setElementValue); | |||
| this.renderer.setElementStyle(element, 'color', setElementValue); | |||
| this.renderer.setElementStyle(element, 'color', 'transparent'); | |||
There was a problem hiding this comment.
Weird! I feel like this input should have never had a color set, because you wouldn't want to ever see that text inside the picker button. Should we just achieve this with a CSS declaration instead of doing this programmatically?
There was a problem hiding this comment.
Good call. I've updated this to use a css class and removed the setting line all together.
Blackbaud-AlexKingman
approved these changes
Jun 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.