Tabs + window controls not displayed with v5 default settings

[redgoldlace]

Describe the bug
I think this is probably pretty self-explanatory, but if you don't enable userChrome.tab.on_bottom you.. just won't
have tabs or window controls at all. Needless to say that makes navigation a bit difficult:

And no. This image is not cropped.

I did some hunting in leptonChrome.css and seem to have found the culprit. Applying the following CSS
unconditionally (i.e, not within a media query) appears to mostly fix the issue:

#titlebar {
  -moz-appearance: none !important;
}

There were a few other weird tweaks i had to make, and for the sake of completeness I'll leave them here if it's helpful
in providing a solution:

Expand codeblock

#navigator-toolbox {
  display: flex !important;
  flex-wrap: wrap;
}

#titlebar,
#nav-bar,
#PersonalToolbar,
#tab-notification-deck,
#tab-notification-deck-template {
  flex-basis: 100%;
}

#titlebar {
  order: 0;
  -moz-appearance: none !important;
  --tabs-navbar-shadow-size: 0px;
}

#tab-notification-deck {
  order: 1;
}

#PersonalToolbar {
  order: 2;
}

#navigator-toolbox {
  padding-top: var(--uc-titlebar-padding) !important;
}

:root:not([sizemode="maximized"]) {
  --uc-titlebar-padding: 0px;
}

:root[sizemode="maximized"] {
  --uc-titlebar-padding: 8px;
}

I'm not sure how many of these changes are necessary. I used the existing CSS and good ol' trial and error until
Firefox behaved. I opened an issue instead of a PR since I... honestly have no idea what I'm doing. This is my first
time interacting with Lepton or Firefox in this way, so I figure somebody else will have a better solution to this.

I really appreciate the project and couldn't live without it. Thanks for your hard work!

Environment:

• Distribution
  • Original Lepton
  • Lepton's photon style
  • Lepton's proton style
• Firefox Version: 99.0.1 (Build ID 20220411174855)
• OS:
  • Linux
  • Windows
  • Mac
  • Other:
• Theme:
  • Light
  • Dark
  • Alpenglow (System: Light)
  • Alpenglow (System: Dark)
  • System Default
    • GTK Theme Name (Linux only):
  • Other: (e.g. Photon Colors, Google Chrome Dark, Fairytale Of Nature)

[black7375]

It works well on Linux, but I'll check Windows. Is it Windows 10?

[redgoldlace]

It is Windows 10, yeah. I notice in your screenshot that the tabs are displayed on the bottom - I'm referring to not enabling that setting. That's when I have no tabs and no window controls at all.

For context, this is (roughly) how I would expect tabs to look with userChrome.tab.on_bottom set to false:

[erwin4270]

If you view/enable the title bar, the tab bar and window controls will show. (temporary workaround for me)
Title bar disabled:

Title bar enabled:

[117649]

@black7375 @kaylynn234
Same here.
And even worse:

Because I have my bookmarks bar auto hide and over page it now not display at under navbar but at top of the window and over everything.

All fixes codes promoted have been applied.
Switch back to 4.6.3 for now.

[black7375]

I created a new release.

Tested with Win7 VM, WIn10 VM, Mac VM

[s-rog]

windowed:

maximized:

@black7375 The top of tab/title bar is cut off when maximized with this new version :/ (but at least it showed up!)