Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lwtheme-mozlightdark is removed #288

Closed
6 of 13 tasks
black7375 opened this issue Dec 8, 2021 · 3 comments
Closed
6 of 13 tasks

lwtheme-mozlightdark is removed #288

black7375 opened this issue Dec 8, 2021 · 3 comments
Labels
Browser::Upstream Changes or bugs from Firefox Class::Color Color, background, blur, etc. Component::Tabbar Tab or tabbar Issue::Bug Something isn't working Priority::High Solve and focus on it first

Comments

@black7375
Copy link
Owner

black7375 commented Dec 8, 2021

Describe the bug

:root[lwtheme-mozlightdark] was selector for default themes(system theme, a default light, and a default dark).

However, it was recently confirmed to be removed from Nightly.
It causes a lot of compatibility issues.

Expected behavior

It should be possible to distinguish whether it is the system default theme, compact light, compact dark or not.

Environment:

Additional context

mozilla/gecko-dev@5dbdec1

It can be converted

:root[style*="--lwt-accent-color: rgb(240, 240, 244); --lwt-text-color: rgba(21, 20, 26);"], /* Light Theme */
:root[style*="--lwt-accent-color: rgb(28, 27, 34); --lwt-text-color: rgba(251, 251, 254);"] /* Dark Theme */
@black7375 black7375 added Issue::Bug Something isn't working Class::Color Color, background, blur, etc. Component::Tabbar Tab or tabbar Browser::Upstream Changes or bugs from Firefox Priority::High Solve and focus on it first labels Dec 8, 2021
@adql
Copy link

adql commented Dec 9, 2021

Is it related to this display problem of unfocused tabs in dark mode? (with auto system theme)

Screenshot from 2021-12-09 12-10-31

I'm on 95.0 (not Nightly), but the Gecko commit you referred to happened before it was released. Same problem on a fresh profile, but if I try it on 91.4.0ecr it works fine. Also on the normal dark theme (not system) it works fine.

If it's unrelated then I'll open a new issue.

@black7375
Copy link
Owner Author

Would you please make a new issue if it's not Nightly?

@adql
Copy link

adql commented Dec 9, 2021

Done. #291

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Browser::Upstream Changes or bugs from Firefox Class::Color Color, background, blur, etc. Component::Tabbar Tab or tabbar Issue::Bug Something isn't working Priority::High Solve and focus on it first
Projects
None yet
Development

No branches or pull requests

2 participants