WinoServer Code fixes #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Moved the IsBackground property assignment into the object initializer for the Thread object. 2. Replaced e.Args[e.Args.Length - 1] with e.Args[^1] 3. Added a conditional check to see if GetWindowThreadProcessId returns 0, which indicates failure. If it fails, throw a Win32Exception with the last Win32 error. 4. Removed unused assignment to the variable process 5. Changed the return type of the ConfigureServices method from IServiceProvider to ServiceProvider. It is more specific and faster. 6. Changed notifyIcon to _notifyIcon according to private var naming scheme. 7. Added the CharSet = CharSet.Unicode attribute to the DllImport declarations to specify that the string arguments should be marshaled as Unicode.
bkaankose
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the IsBackground property assignment into the object initializer for the Thread object.
Replaced e.Args[e.Args.Length - 1] with e.Args[^1]
Added a conditional check to see if GetWindowThreadProcessId returns 0, which indicates failure. If it fails, throw a Win32Exception with the last Win32 error.
Removed unused assignment to the variable process
Changed the return type of the ConfigureServices method from IServiceProvider to ServiceProvider. It is more specific and faster.
Changed notifyIcon to _notifyIcon according to private var naming scheme.
Added the CharSet = CharSet.Unicode attribute to the DllImport declarations to specify that the string arguments should be marshaled as Unicode.