Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually updating dependencies #15

Merged
merged 4 commits into from
May 13, 2024
Merged

Conversation

jhbeskow
Copy link
Contributor

🎟️ Tracking

🚧 Type of change

  • 🧹 Tech debt (refactoring, code cleanup, dependency upgrades, etc.)

📔 Objective

Updating dependency versions to the latest available without breaking changes.

📋 Code changes

  • src/sm-operator/Dockerfile: We are targeting Go v1.21
  • src/sm-operator/go.mod: Updating direct dependencies to latest versions that do not require Go 1.22 or break other libraries.
  • src/sm-operator/go.sum: Updating direct dependencies to latest versions that do not require Go 1.22 or break other libraries.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@jhbeskow jhbeskow requested a review from a team as a code owner May 13, 2024 16:54
@jhbeskow jhbeskow requested a review from Thomas-Avery May 13, 2024 16:54
src/sm-operator/go.mod Outdated Show resolved Hide resolved
src/sm-operator/go.mod Outdated Show resolved Hide resolved
@jhbeskow jhbeskow requested a review from Thomas-Avery May 13, 2024 18:54
Copy link
Contributor

@Thomas-Avery Thomas-Avery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jhbeskow jhbeskow merged commit ecd2b9d into main May 13, 2024
3 checks passed
@jhbeskow jhbeskow deleted the features/dependency_updates branch May 13, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants