-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-3084] fix: Fix null handling in SendLicenseExpiredAsync method #3122
Conversation
Thank you for your contribution! We've added this to our internal Community PR board for review. |
Fixed Issues
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@GSWXXN Appreciate the contribution! I've reviewed this and since it's just a null-check addition, I'm going to push it through. You can expect this change to be in the release on 9/17. Thanks again! |
Type of change
Objective
Fixed that when the user license is not available, there may be an error when logging in to Bitwarden, and the user may not receive the license expiration reminder email
Code changes
CoreHelpers.SanitizeForEmail()
method. Without this change, the specific location in the code (at this link) would throw an exception.Before you submit
dotnet format --verify-no-changes
) (required)