PM-15804, PM-17130: Add logic to monitor when the screen on state to ensure the vault locks properly

[david-livefront]

🎟️ Tracking

PM-17130
PM-15804

📔 Objective

This PR adds a broadcast receiver to the VaultLockManager in order to ensure that we lock the vault at the soonest possible moment.

There seems to be an issue in the way delay works inside a coroutine scope when the screen is off. The delay will take significantly longer to complete and cause the vault to not lock when it is supposed to. This new solution restarts the delay with an appropriate remaining time when the screen is turned back on to ensure we lock the vault correctly.

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
  issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[github-actions]

Checkmarx One – Scan Summary & Details – 33ab6969-a053-46af-aed7-9c3ffee6cbb9

New Issues (12)

Checkmarx found the following issues in this Pull Request

Severity	Issue	Source File / Package	Checkmarx Insight
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt: 346	details Method Lambda at line 346 of /app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt sends use... Attack Vector
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt: 346	details Method Lambda at line 346 of /app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt sends use... Attack Vector
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/createaccount/CreateAccountViewModel.kt: 321	details Method Lambda at line 321 of /app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/createaccount/CreateAccountViewModel.kt sends user information ... Attack Vector
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/createaccount/CreateAccountViewModel.kt: 321	details Method Lambda at line 321 of /app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/createaccount/CreateAccountViewModel.kt sends user information ... Attack Vector
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModel.kt: 905	details Method Lambda at line 905 of /app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModel.kt sends user information outside the ... Attack Vector
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/data/tools/generator/repository/utils/GeneratorRepositoryExtensions.kt: 11	details Method generateRandomString at line 11 of /app/src/main/java/com/x8bit/bitwarden/data/tools/generator/repository/utils/GeneratorRepositoryExtension... Attack Vector
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/data/autofill/manager/AutofillTotpManagerImpl.kt: 37	details Method tryCopyTotpToClipboard at line 37 of /app/src/main/java/com/x8bit/bitwarden/data/autofill/manager/AutofillTotpManagerImpl.kt sends user info... Attack Vector
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/deleteaccount/DeleteAccountViewModel.kt: 94	details Method Lambda at line 94 of /app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/deleteaccount/DeleteAccountViewMode... Attack Vector
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt: 237	details Method Lambda at line 237 of /app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt sends use... Attack Vector
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt: 259	details Method Lambda at line 259 of /app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt sends use... Attack Vector
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt: 248	details Method Lambda at line 248 of /app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt sends use... Attack Vector
	Use_of_Hardcoded_Password	/app/src/main/java/com/x8bit/bitwarden/data/autofill/util/HtmlInfoExtensions.kt: 20	Attack Vector

[dseverns-livefront]

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.31%. Comparing base (e63a549) to head (d80fe2f).
Report is 1 commits behind head on release/2025.01-rc14.

Additional details and impacted files

@@                   Coverage Diff                    @@
##           release/2025.01-rc14    #4618      +/-   ##
========================================================
- Coverage                 88.31%   88.31%   -0.01%     
========================================================
  Files                       603      603              
  Lines                     40269    40291      +22     
  Branches                   5697     5697              
========================================================
+ Hits                      35562    35581      +19     
  Misses                     2721     2721              
- Partials                   1986     1989       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[david-livefront]

Thanks @phil-livefront & @dseverns-livefront